Use salt['pillar.get'] accessor instead of pillar.get

Fixes salt-lint error 211

bird/exporter.sls

-{%- set gopath = pillar.get('golang:gopath', '/usr/local/go') %}
+{%- set gopath = salt['pillar.get']('golang:gopath', '/usr/local/go') %}
 
 include:
   - golang
@@ -14,7 +14,7 @@ bird-exporter:
     - cwd: {{ gopath }}/src/github.com/czerwonk/bird_exporter
     - name: go get -v -u github.com/czerwonk/bird_exporter
     - env:
-        GOPATH: {{ pillar.get('golang:gopath', '/usr/local/go') }}
+        GOPATH: {{ salt['pillar.get']('golang:gopath', '/usr/local/go') }}
     - require:
       - pkg: golang
       - pkg: git

bird/files/kernel.conf.j2

@@ -7,12 +7,12 @@ table kernel_T_{{ kernel_table }};
 protocol kernel kernel_{{ kernel_table }} {
 	export filter  {
 {% if ip_version == 4 %}
-{%- if (pillar.get('source_ip_4', [])) in grains['ip_interfaces']['lo'] %}
+{%- if (salt['pillar.get']('source_ip_4', [])) in grains['ip_interfaces']['lo'] %}
 		krt_prefsrc = {{ pillar['source_ip_4'] }};
 {%- endif %}
 		accept;
 {% elif ip_version == 6 %}
-{%- if (pillar.get('source_ip_6', [])) in grains['ip_interfaces']['lo'] %}
+{%- if (salt['pillar.get']('source_ip_6', [])) in grains['ip_interfaces']['lo'] %}
 		krt_prefsrc = {{ pillar['source_ip_6'] }};
 {%- endif %}
 		accept;
@@ -31,7 +31,7 @@ protocol kernel kernel_{{ kernel_table }} {
 	import none;
 {%- endif %}
 	device routes on;
-{%- if 'vmhost' in pillar.get('roles', []) %}
+{%- if 'vmhost' in salt['pillar.get']('roles', []) %}
 	learn;
 {%- endif %}
 

bird/files/ospf.conf.j2

@@ -38,7 +38,7 @@ protocol ospf IGP {
 		};
 
 {%- if type == 'ospf6' %}
-{%- if 'nat64' in pillar.get('roles', []) %}
+{%- if 'nat64' in salt['pillar.get']('roles', []) %}
 		stubnet 64:ff9b::/96;
 {%- endif %}
 {%- endif %}

bird/init.sls

 include:
   - ferm
   - bird.exporter
-{%- if 'gateway' in pillar.get('roles', [])  %}
+{%- if 'gateway' in salt['pillar.get']('roles', [])  %}
   - bird.radv
   - bird.domains
 {%- endif %}
@@ -155,7 +155,7 @@ bird6:
       - pkg: bird
       - file: /etc/bird/bird6.d
 
-{%- if 'babel' in pillar.get('roles', []) %}
+{%- if 'babel' in salt['pillar.get']('roles', []) %}
 /etc/bird/bird6.d/910-kernel.conf:
   file.managed:
     - source: salt://bird/files/kernel.conf.j2
@@ -170,7 +170,7 @@ bird6:
     - require:
       - pkg: bird
       - file: /etc/bird/bird6.d
-{%- if 'gateway' in pillar.get('roles', []) %}
+{%- if 'gateway' in salt['pillar.get']('roles', []) %}
 /etc/bird/bird6.d/912-kernel.conf:
   file.managed:
     - source: salt://bird/files/kernel.conf.j2

bird/radv.sls

 include:
   - bird
 
-{% for domain_key, domain_val in pillar.get('domains', {}).items() %}
+{% for domain_key, domain_val in salt['pillar.get']('domains', {}).items() %}
 
 /etc/bird/bird6.d/50-radv-dom{{ domain_val['domain_id'] }}.conf:
   file.managed:

cadvisor/init.sls

-{% set docker = pillar.get('docker', {}) %}
+{% set docker = salt['pillar.get']('docker', {}) %}
 {% set volume = docker.volume_root | default('/srv/docker') ~ '/cadvisor' %}
 {% set image = 'google/cadvisor:latest' %}
-{% set cadvisor = pillar.get('cadvisor', {}) %}
+{% set cadvisor = salt['pillar.get']('cadvisor', {}) %}
 {% set metrics = cadvisor.get('metrics', {}) %}
 {% set port = '9999' %}
 

cpthook-gitlab/init.sls

-{%- set gopath = pillar.get('golang:gopath', '/usr/local/go') %}
+{%- set gopath = salt['pillar.get']('golang:gopath', '/usr/local/go') %}
 {%- set project = 'cpthook' %}
 {%- set uri = 'github.com/fleaz/CptHook' %}
 

dnsresolver/kresd/files/kresd.conf.j2

@@ -21,7 +21,7 @@ user('knot-resolver','knot-resolver')
 
 cache.size = 1*GB
 
-{%- if 'forwarder' in pillar.get('roles', []) %}
+{%- if 'forwarder' in salt['pillar.get']('roles', []) %}
 {%- if salt['pillar.get']('dns:dns64', True) and salt['pillar.get']('dns:forwarder:dns64', True) and salt['pillar.get']('dns:kresd:dns64', True) %}
 modules = { dns64 = '64:ff9b::' }
 {%- endif %}

dnsresolver/unbound/exporter.sls

-{%- set gopath = pillar.get('golang:gopath', '/usr/local/go') %}
+{%- set gopath = salt['pillar.get']('golang:gopath', '/usr/local/go') %}
 {%- set gopkg = 'github.com/kumina/unbound_exporter' %}
 
 include:
@@ -12,7 +12,7 @@ unbound-exporter:
     - cwd: {{ gopath }}/src/{{ gopkg }}
     - name: go get -v -u {{ gopkg }}
     - env:
-        GOPATH: {{ pillar.get('golang:gopath', '/usr/local/go') }}
+        GOPATH: {{ salt['pillar.get']('golang:gopath', '/usr/local/go') }}
     - require:
       - pkg: golang
       - git: unbound-exporter

dnsresolver/unbound/files/unbound.conf.j2

@@ -24,7 +24,7 @@ server:
 	harden-glue: yes
 	harden-dnssec-stripped: yes
 	harden-below-nxdomain: no
-{%- if 'resolver' in pillar.get('roles', []) %}
+{%- if 'resolver' in salt['pillar.get']('roles', []) %}
 	qname-minimisation: yes
 {%- else %}
 	qname-minimisation: no
@@ -36,7 +36,7 @@ server:
 	rrset-roundrobin: yes
 	minimal-responses: no
 
-{%- if 'forwarder' in pillar.get('roles', []) and salt['pillar.get']('dns:dns64', True) and salt['pillar.get']('dns:forwarder:dns64', True) and salt['pillar.get']('dns:unbound:dns64', True) %}
+{%- if 'forwarder' in salt['pillar.get']('roles', []) and salt['pillar.get']('dns:dns64', True) and salt['pillar.get']('dns:forwarder:dns64', True) and salt['pillar.get']('dns:unbound:dns64', True) %}
 	# DNS64
 	module-config: "dns64 validator iterator"
 	dns64-prefix: 64:ff9b::/96
@@ -68,7 +68,7 @@ forward-zone:
 	forward-host: c.ns.ffffm.net
 	forward-host: d.ns.freifunk-frankfurt.de
 
-{%- if 'forwarder' in pillar.get('roles', []) %}
+{%- if 'forwarder' in salt['pillar.get']('roles', []) %}
 forward-zone:
 	name: "."
 	#recursiveA.ns.as64475.net

docker/container.sls

-{% set docker = pillar.get('docker', {}) %}
+{% set docker = salt['pillar.get']('docker', {}) %}
 {% set images = docker.get('images', {}) %}
 {% set containers = docker.get('containers', []) %}
 

docker/images.sls

-{% set docker = pillar.get('docker', {}) %}
+{% set docker = salt['pillar.get']('docker', {}) %}
 {% set images = docker.get('images', {}) %}
 
 

dovecot/init.sls

 {% if grains['osfinger'] == "Debian-9" %}
-{%- if 'dovecot' in pillar.get('roles', []) %}
+{%- if 'dovecot' in salt['pillar.get']('roles', []) %}
 include:
   - .dovecot
 {%- endif %}

fastd/exporter.sls

-{%- set gopath = pillar.get('golang:gopath', '/usr/local/go') %}
+{%- set gopath = salt['pillar.get']('golang:gopath', '/usr/local/go') %}
 {%- set gopkg = 'git.darmstadt.ccc.de/ffda/fastd-exporter' %}
 
 include:
@@ -12,7 +12,7 @@ fastd-exporter:
     - cwd: {{ gopath }}/src/{{ gopkg }}
     - name: go get -v -u {{ gopkg }}
     - env:
-        GOPATH: {{ pillar.get('golang:gopath', '/usr/local/go') }}
+        GOPATH: {{ salt['pillar.get']('golang:gopath', '/usr/local/go') }}
     - require:
       - pkg: golang
       - git: fastd-exporter

fastd/instances.sls

 # for each domain
-{%- for domain_key, domain_val in pillar.get('domains', {}).items() %}
+{%- for domain_key, domain_val in salt['pillar.get']('domains', {}).items() %}
 {%- set domain_id = domain_val['domain_id'] %}
 
 # assign fastd configuration

golang/init.sls

@@ -21,5 +21,5 @@ golang-env:
   file.managed:
      - name: /etc/profile.d/go
      - contents:
-         export GOPATH={{ pillar.get('golang:gopath', '/usr/local/go') }}
+         export GOPATH={{ salt['pillar.get']('golang:gopath', '/usr/local/go') }}
          export PATH=$PATH:$GOPATH/bin

grafana/init.sls

-{%- if 'grafana' in pillar.get('roles', []) %}
+{%- if 'grafana' in salt['pillar.get']('roles', []) %}
 include:
   - grafana.grafana
 {%- endif %}

graphite/init.sls

 {%- set includes = [] %}
-{%- if 'go-carbon' in pillar.get('roles') %}
+{%- if 'go-carbon' in salt['pillar.get']('roles') %}
   {%- do includes.append('.go-carbon') %}
 {%- endif %}
-{%- if 'carbonapi' in pillar.get('roles') %}
+{%- if 'carbonapi' in salt['pillar.get']('roles') %}
   {%- do includes.append('.carbonapi') %}
 {%- endif %}
 

haproxy/init.sls

 include:
-{%- if 'haproxy' in pillar.get('roles', []) %}
+{%- if 'haproxy' in salt['pillar.get']('roles', []) %}
   - .install
 {%- endif %}

kea-dhcp/files/kea-dhcp4.conf.j2

 {%- set interfaces = salt['pillar.get']('kea-dhcp:v4:interfaces', []) -%}
-{%- for domain, domainData in pillar.get('domains', {}).items() -%}
+{%- for domain, domainData in salt['pillar.get']('domains', {}).items() -%}
 {%- do interfaces.append(domain ~ '-br') -%}
 {%- endfor -%}
 {
@@ -39,7 +39,7 @@
     }{% if not loop.last %},{% endif %}
 {%- endfor %}
 
-{% for domain, domainData in pillar.get('domains', {}).items() if 'IPv4' in domainData %}
+{% for domain, domainData in salt['pillar.get']('domains', {}).items() if 'IPv4' in domainData %}
 {%- set instance = domainData.IPv4 %}
 
 {%- if salt['pillar.get']('kea-dhcp:v4:subnets', []) and instance.subnets %},{%- endif %}